Add logger and ostruct to the gemspec #13499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hswong3i
added a commit
to alvistack/hashicorp-vagrant
that referenced
this pull request
Sep 6, 2024
git clean -xdf
git submodule sync --recursive
git submodule update --recursive --init
git submodule foreach --recursive git clean -xdf
gem build vagrant.gemspec -o ../vagrant-2.4.1.gem
bundle config set --local path ./bundle
bundle install --verbose --standalone
bundle config set --local cache_all true
bundle config set --local cache_all_platforms true
bundle cache
mv ../vagrant-2.4.1.gem ./vendor/cache/
rm -rf .bundle bundle vendor/bundle Gemfile.lock
tar zcvf ../vagrant_2.4.1.orig.tar.gz --exclude=.git .
debuild -uc -us
cp vagrant.spec ../vagrant_2.4.1-1.spec
cp vagrant.rpmlintrc /osc/home\:alvistack/hashicorp-vagrant-2.4.1/
cp ../vagrant*2.4.1*.{gz,xz,spec,dsc} /osc/home\:alvistack/hashicorp-vagrant-2.4.1/
rm -rf ../vagrant*2.4.1*.*
See https://salsa.debian.org/ruby-team/vagrant/-/blob/master/debian/patches/0001-bin-vagrant-silence-warning-about-installer.patch
See https://salsa.debian.org/ruby-team/vagrant/-/blob/master/debian/patches/0005-Relax-dependency-resolution.patch
See https://build.opensuse.org/package/show/openSUSE:Factory/vagrant
See hashicorp#13390
See hashicorp#13499
Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
hswong3i
added a commit
to alvistack/hashicorp-vagrant
that referenced
this pull request
Sep 18, 2024
git clean -xdf
git submodule sync --recursive
git submodule update --recursive --init
git submodule foreach --recursive git clean -xdf
gem build vagrant.gemspec -o ../vagrant-2.4.1.gem
bundle config set --local path ./bundle
bundle install --verbose --standalone
bundle config set --local cache_all true
bundle config set --local cache_all_platforms true
bundle cache
mv ../vagrant-2.4.1.gem ./vendor/cache/
rm -rf .bundle bundle vendor/bundle Gemfile.lock
tar zcvf ../vagrant_2.4.1.orig.tar.gz --exclude=.git .
debuild -uc -us
cp vagrant.spec ../vagrant_2.4.1-1.spec
cp vagrant.rpmlintrc /osc/home\:alvistack/hashicorp-vagrant-2.4.1/
cp ../vagrant*2.4.1*.{gz,xz,spec,dsc} /osc/home\:alvistack/hashicorp-vagrant-2.4.1/
rm -rf ../vagrant*2.4.1*.*
See https://salsa.debian.org/ruby-team/vagrant/-/blob/master/debian/patches/0001-bin-vagrant-silence-warning-about-installer.patch
See https://salsa.debian.org/ruby-team/vagrant/-/blob/master/debian/patches/0005-Relax-dependency-resolution.patch
See https://build.opensuse.org/package/show/openSUSE:Factory/vagrant
See hashicorp#13390
See hashicorp#13499
See hashicorp#13503
Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
hswong3i
added a commit
to alvistack/hashicorp-vagrant
that referenced
this pull request
Oct 29, 2024
git clean -xdf
git submodule sync --recursive
git submodule update --recursive --init
git submodule foreach --recursive git clean -xdf
gem build vagrant.gemspec -o ../vagrant-2.4.1.gem
bundle config set --local path ./bundle
bundle install --verbose --standalone
bundle config set --local cache_all true
bundle config set --local cache_all_platforms true
bundle cache
mv ../vagrant-2.4.1.gem ./vendor/cache/
rm -rf .bundle bundle vendor/bundle Gemfile.lock
tar zcvf ../vagrant_2.4.1.orig.tar.gz --exclude=.git .
debuild -uc -us
cp vagrant.spec ../vagrant_2.4.1-1.spec
cp vagrant.rpmlintrc /osc/home\:alvistack/hashicorp-vagrant-2.4.1/
cp ../vagrant*2.4.1*.{gz,xz,spec,dsc} /osc/home\:alvistack/hashicorp-vagrant-2.4.1/
rm -rf ../vagrant*2.4.1*.*
See https://salsa.debian.org/ruby-team/vagrant/-/blob/master/debian/patches/0001-bin-vagrant-silence-warning-about-installer.patch
See https://salsa.debian.org/ruby-team/vagrant/-/blob/master/debian/patches/0005-Relax-dependency-resolution.patch
See https://build.opensuse.org/package/show/openSUSE:Factory/vagrant
See hashicorp#13390
See hashicorp#13499
See hashicorp#13513
Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
chrisroberts
approved these changes
Oct 30, 2024
|
Thanks! |
brlin-tw
reviewed
Nov 2, 2024
| @@ -16,6 +16,8 @@ Gem::Specification.new do |s| | |||
| s.required_rubygems_version = ">= 1.3.6" | |||
|
|
|||
| s.add_dependency "base64", "~> 0.2.0" | |||
| s.add_dependency "logger", "~> 1.6.1" | |||
There was a problem hiding this comment.
This line should probably be changed to ~>1.0 or ~>1.6, refer to #13527 for more info.
There was a problem hiding this comment.
I don't speak Ruby so I'm not sure (shrugs), I'll leave the judgement to you.
hswong3i
added a commit
to alvistack/hashicorp-vagrant
that referenced
this pull request
Nov 2, 2024
git clean -xdf
git submodule sync --recursive
git submodule update --recursive --init
git submodule foreach --recursive git clean -xdf
gem build vagrant.gemspec -o ../vagrant-2.4.2.gem
bundle config set --local path ./bundle
bundle install --verbose --standalone
bundle config set --local cache_all true
bundle config set --local cache_all_platforms true
bundle cache
mv ../vagrant-2.4.2.gem ./vendor/cache/
rm -rf .bundle bundle vendor/bundle Gemfile.lock
tar zcvf ../vagrant_2.4.2.orig.tar.gz --exclude=.git .
debuild -uc -us
cp vagrant.spec ../vagrant_2.4.2-1.spec
cp vagrant.rpmlintrc /osc/home\:alvistack/hashicorp-vagrant-2.4.2/
cp ../vagrant*2.4.2*.{gz,xz,spec,dsc} /osc/home\:alvistack/hashicorp-vagrant-2.4.2/
rm -rf ../vagrant*2.4.2*.*
See https://salsa.debian.org/ruby-team/vagrant/-/blob/master/debian/patches/0001-bin-vagrant-silence-warning-about-installer.patch
See https://salsa.debian.org/ruby-team/vagrant/-/blob/master/debian/patches/0005-Relax-dependency-resolution.patch
See https://build.opensuse.org/package/show/openSUSE:Factory/vagrant
See hashicorp#13499
Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
brlin-tw
added a commit
to brlin-tw/vagrant
that referenced
this pull request
Nov 4, 2024
…lugin installation Vagrant version 2.4.2 introduced a patch(512bb74) that sets the logger gem dependency to "~>1.6.1", which is too strict and prevents many Vagrant plugins from being installed. This patch tones down the dependency specification to mitigate this problem. Fixes hashicorp#13527. Refer-to: Add logger and ostruct to the gemspec by hswong3i · Pull Request hashicorp#13499 · hashicorp/vagrant <hashicorp#13499>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
logger and ostruct will no longer be the default gem in the Ruby 3.5, without this patch following warning message may come from ruby 3.3+